TOOLS/PERF: changes to enable the rocm perf modules #4434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
dmitrygx
reviewed
Nov 12, 2019
dmitrygx
approved these changes
Nov 12, 2019
Mellanox CI: FAILED on 5 of 25 workers (click for details)Note: the logs will be deleted after 19-Nov-2019
|
Mellanox CI: FAILED on 5 of 25 workers (click for details)Note: the logs will be deleted after 19-Nov-2019
|
|
bot:retest |
Mellanox CI: FAILED on 9 of 25 workers (click for details)Note: the logs will be deleted after 20-Nov-2019
|
@paklui the failures seem to be related to your PR: |
Yes, noticed the Mellanox CI was giving out errors due to it having a much older version (1.5) of HIP and ROCm stack. I asked @yosefe earlier to have the sysadmin to update the ROCm stack to the latest version 2.9. I think Mellanox CI runs on CentOS, the instructions for the latest ROCm setup: https://rocm.github.io/ROCmInstall.html#centosrhel-7-76-support I checked my log files on a couple of systems they seem to be compiling file without any issues. |
|
Included additional checks to prevent old HIP version from building ROCm perftest compiles when hipconfig is in recent version: skip building ROCm perftest when hipconfig is old: skip building ROCm perftest when hipconfig is not available: |
Mellanox CI: FAILED on 7 of 25 workers (click for details)Note: the logs will be deleted after 05-Dec-2019
|
Mellanox CI: FAILED on 8 of 25 workers (click for details)Note: the logs will be deleted after 05-Dec-2019
|
|
bot:mlx:retest |
Mellanox CI: FAILED on 8 of 25 workers (click for details)Note: the logs will be deleted after 07-Dec-2019
|
|
bot:mlx:retest |
Mellanox CI: FAILED on 7 of 25 workers (click for details)Note: the logs will be deleted after 07-Dec-2019
|
|
bot:mlx:retest |
Mellanox CI: FAILED on 5 of 25 workers (click for details)Note: the logs will be deleted after 08-Dec-2019
|
|
bot:mlx:retest |
@paklui is there any missing lib? |
souravzzz
referenced
this pull request
in ROCm/ucx
Dec 4, 2019
@yosefe should be there if the hip_hcc rpm is installed on the test node. I don't have access to see the logs in MellanoxLab, is it where it's failing? |
See #4434 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I am including the changes to enable the perf modules for rocm to get built, so we can run ucx_perftest on rocm device. This PR is a do-over from the previous PR #4349 due to issue with commit title
Why ?
The rocm support on ucx_perftest is not enabled, so just to enable the ucx_perftest. This change does not change the existing functionality of rocm in ucx.